refactor: make CommentView more amenable to subclassing.#8783
Merged
gonfunko merged 1 commit intoRaspberryPiFoundation:rc/v12.0.0from Feb 24, 2025
Merged
refactor: make CommentView more amenable to subclassing.#8783gonfunko merged 1 commit intoRaspberryPiFoundation:rc/v12.0.0from
gonfunko merged 1 commit intoRaspberryPiFoundation:rc/v12.0.0from
Conversation
rachel-fenichel
approved these changes
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
This PR makes
CommentViewmore compatible with subclassing. Scratch has a subclass, which it uses to provide a bubble-based comment view attached by a line to its parent block. This PR allows that subclass to implementISelectable, which requiresthis.workspaceto be public, and allows for it to correctly update its disposal state around additional disposal logic.